High local taxes, housing costs and a drop in finance-industry jobs mean New York City is losing its allure.