Usha Vance, who clerked for Chief Justice John G. Roberts Jr. and was a top editor on The Yale Law Journal, referred to herself as a “former lawyer” in a recent appearance.